Skip to content

add new resource OptionGroup - #257

Open
kprahulraj wants to merge 2 commits into
aws-controllers-k8s:mainfrom
kprahulraj:dboptiongroup
Open

add new resource OptionGroup#257
kprahulraj wants to merge 2 commits into
aws-controllers-k8s:mainfrom
kprahulraj:dboptiongroup

Conversation

@kprahulraj

@kprahulraj kprahulraj commented Dec 12, 2025

Copy link
Copy Markdown

Issue #2065

Description of changes:

The Amazon RDS OptionGroup resource represents the RDS Aurora Serverless API's command-line/configuration options for DB clusters.

  • generator config file to un-ignore OptionGroup resource
  • generate RDS service controller with support for the OptionGroup resource
  • e2e python test for CRUD operations for a OptionGroup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
ack-prow Bot requested review from knottnt and michaelhtm December 12, 2025 22:54
@kprahulraj

kprahulraj commented Dec 12, 2025

Copy link
Copy Markdown
Author

/retest

@kprahulraj
kprahulraj force-pushed the dboptiongroup branch 2 times, most recently from 0d2c010 to 2090dac Compare December 16, 2025 03:07
michaelhtm
michaelhtm reviewed Dec 16, 2025
View reviewed changes

@michaelhtm michaelhtm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kprahulraj
left a few comments below

Comment thread apis/v1alpha1/option_group.go Outdated
Comment thread apis/v1alpha1/option_group.go Outdated
knottnt
knottnt reviewed Dec 18, 2025
View reviewed changes

@knottnt knottnt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the API Reference for ModifyOptionGroup I can see that it provides request parameters for configuring Options within the OptionGroup. I think we likely need to update this PR so that users can configure those values.

@knottnt knottnt self-assigned this Jun 18, 2026
kprahulraj and others added 2 commits June 19, 2026 10:05
@kprahulraj @michaelhtm
add new resource OptionGroup
7066af8
@michaelhtm
feat: support configuring and updating OptionGroup options
32c3cb2 
Add Spec.Options (from ModifyOptionGroup.OptionsToInclude) with a
create-then-modify flow and a custom update that computes the
OptionsToInclude/OptionsToRemove sets. Observed options surface in
Status.OptionStatuses. Mark Description, EngineName and
MajorEngineVersion immutable to avoid an infinite reconcile loop on
fields ModifyOptionGroup cannot change.
@ack-prow

ack-prow Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kprahulraj
Once this PR has been reviewed and has the lgtm label, please ask for approval from knottnt. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knottnt knottnt knottnt left review comments
@michaelhtm michaelhtm michaelhtm left review comments

Assignees

@knottnt knottnt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kprahulraj @knottnt @michaelhtm