Add inline policy recommendation for secret management - #251
Conversation
When only using AmazonRDSFullAccess and setting a DBInstance `spec.manageMasterUserPassword` to true, the controller would fail on DBInstanceCreate because of insufficient permissions (first to use KMS keys then to create passwords) . This allows the controller to create and manage secrets in secrets manager.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tbarizien The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tbarizien. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 180d of inactivity. |
|
Stale issues rot after 60d of inactivity. |
Issue:
When only using AmazonRDSFullAccess and setting a DBInstance
spec.manageMasterUserPasswordto true, the controller would fail on DBInstanceCreate because of insufficient permissions (first to use KMS keys then to create passwords) .This allows the controller to create and manage secrets in secrets manager.
Description of changes:
Adds a recommended-inline-policy file containing the necessary policy for the RDS controller to manage secrets in the AWS SecretStore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.