Fix repeated incomplete-handshake false positives - #78
Merged
Conversation
awlx
added a commit
that referenced
this pull request
Aug 9, 2026
Fix repeated incomplete-handshake false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A SYN whose final ACK was not observed remained in
pending_handshakesindefinitely. The collector emitted that same entry on every one-second map poll, and the analyzer interpreted the polling cadence as client connection timing. Repeated snapshots therefore producedincomplete_handshake + timing_patterndetections for ordinary traffic and mechanically raised confidence.Safety
The change is symmetric for IPv4 and IPv6. It does not make enforcement stricter, alter dry-run behavior, or change eBPF programs. Deploy in dry-run first and confirm the repeated signature collapses before considering enforcement.
Validation
go test -race ./pkg/collector ./pkg/analyzer ./pkg/patternsmake portable-testmake analyzermake yeetctlgit diff --checkLinux CI is still required for collector/eBPF build, verifier/runtime, and HAProxy end-to-end coverage because the local host is macOS.