Repository navigation
Allow service-api-components-bundle v2 - #23
Merged
diego1auto merged 1 commit intoSep 18, 2026
Merged
diego1auto merged 1 commit into
diego1auto merged 1 commit into
Conversation
- Widen the auto1-oss/service-api-components-bundle constraint to ^1.0|^2.0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
diego1auto
approved these changes
Sep 18, 2026
dmitry-auto1
approved these changes
Sep 18, 2026
dmitry-auto1
left a comment
There was a problem hiding this comment.
Approved. Checked that components-bundle v2.0.0 (PR #20 — drop PHP 7.4/Symfony 4 to unblock monolog 3) is API-compatible with this bundle: the only BC breaks in v2 are LoggerAwareTrait::setLogger() becoming : void and the NameConverter/Encoder signature updates. This repo has no fluent setLogger() calls (all call sites are DI calls: entries or tests that ignore the return value) and does not extend the changed NameConverter/Encoder classes. Keeping ^1.0 in the union preserves PHP 7 resolvability.
vi-auto1
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow this bundle to be installed with
auto1-oss/service-api-components-bundlev2.Changes
auto1-oss/service-api-components-bundleconstraint from^1.0to^1.0|^2.0.Tests
No code change, so no test change.
composer validatepasses; the remaining warnings are pre-existing unbound>=constraints on symfony packages.Out of scope
^1.0pins in the other consumers of this package.🤖 Generated with Claude Code