Skip to content

Fix issues due to Semigroup and MonadFail instances #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acarrico wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issues due to Semigroup and MonadFail instances #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc1ec5b
Adds Semigroup instance for EvStream
acarrico Oct 22, 2020
091e403
Relaxes pattern match to avoid missing MonadFail instance
acarrico Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Control/FRPNow/EvStream.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ newtype EvStream a = S { getEs :: Behavior (Event [a]) }
instance Functor EvStream where
fmap f (S b) = S $ (fmap f <$>) <$> b

instance Semigroup (EvStream a) where
(<>) = merge

instance Monoid (EvStream a) where
mempty = emptyEs
mappend = merge
Expand Down Expand Up @@ -309,7 +312,7 @@ callbackStream = do mv <- sync $ newIORef ([], Nothing)
return (S s, func mv) where
loop :: IORef ( [a], Maybe (() -> IO ()) ) -> Now ([a], Behavior (Event [a]))
loop mv =
do (l, Nothing) <- sync $ readIORef mv
do (l, _) <- sync $ readIORef mv
(e,cb) <- callback
sync $ writeIORef mv ([], Just cb)
es <- planNow $ loop mv <$ e
Expand Down