feat(fableloom): add entry, hold-loop, and transition playback assets (#5382) - #5401
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements entry clips, hold-loop variations, transition-specific exits, and audio-occupancy validation for FableLoom interactive narratives (part of #5377).
videoHistoryIdfallback while introducingplaybackAssets(entryVideoHistoryId,holdLoopVideoHistoryIds,exitByTransition,audioOccupancy,provenance) andinteractionWindow(enabled,protagonistCharacterId,protagonistPresence,audioTarget,ambientDuckDb,holdLoopRotation).entry,hold,exit, andendedphases on the player surface and backend resolver with hold-loop rotation (deterministic,shuffle,sequential) and transition exit clip rehearsing before node advancement.safeForLiveVoiceis enforcedfalseif dialogue or blocking sound effects are present). Calculates ambient ducking factors (-8 dBdefault) during live interaction.inspectNodeProductionReadiness,inspectEpisodeProductionReadiness) inspect scenes and report actionable findings on the canvas, node editor, and validation panel without AI provider calls.Key Changes
server/lib/fableLoomPlayback.js&server/lib/fableLoomLimits.js: Pure helpers for audio occupancy validation, track muxing, ambient ducking math, deterministic asset resolution across phases, and production readiness analyzers.server/lib/fableLoomValidation.js: Zod validation schemas foraudioOccupancySchema,playbackAssetsSchema, andinteractionWindowSchema.server/services/fableLoom/records.js: Node sanitizers, patch handlers, andattachNodePlaybackAssetservice helper.server/routes/fableLoom.js: Surface production readiness on episode validation and node readiness endpoint.client/src/components/fableloom/LoomPlayPanel.jsx: Rehearsal player running the 4-phase state machine, hold loop rotation, transition exit clip playback, live voice window indicator, and inspection details drawer.client/src/components/fableloom/LoomNodeEditor.jsx: Live interaction controls, ducking slider, hold rotation selector, and readiness findings alert.client/src/components/fableloom/LoomValidationPanel.jsx: Production readiness section in episode analysis.Closes #5382