refactor: retire overlap acceptsLyrics wire shim - #5399
Merged
Conversation
The status-root lyrics feature has shipped through five releases after #4826, so supported peers no longer need the duplicate per-capability signal. Keep inputAssets capability compatibility because it remains genuinely per-model.
Keep the retired acceptsLyrics field out of the wire contract while treating a present pre-features status as evidence of an old peer build. Cover both the positive feature denial and the legacy status shape at the route boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cd server && npm test -- --run lib/federatedMediaWire.test.js routes/music.test.js services/federatedMediaProvider.test.jscd client && npm test -- --run src/lib/federatedMediaReadiness.test.js src/components/music/MusicGenPanel.test.jsxscripts/checkNpmVersion.test.js; 35,591 other tests passed.Closes #4850