Conversation
Both surfaced in the v2.47.0 release full-CI run, which runs the whole suite rather than the impact-scoped subset the PR checks use. - llamaServerManager: the brew-keg-link test flipped findCommandOnPath on a 15ms timer racing the install child's own 10ms exit. On a loaded Windows runner the timer won, so the binary looked already-linked and 'brew link' never ran. Key the flip off the link spawn instead, which is what actually puts the binary on PATH. - SongBookViewer: the 'm' metronome shortcut is a window listener attached in an effect, but findByLabelText resolves on the DOM mutation that can commit first, dropping the keystroke. Retry the keystroke until it lands.
Same class as the two races in ab0affb: findByLabelText resolves when the textarea's DOM node appears, but TracksManager hydrates the form from the loaded track in an effect that can commit afterwards. Under CI load that hydration overwrote the typed prompt, so 'Design with AI' saved the original and the updateTrack assertion failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v2.47.0 release PR (#4721) merged, but the Release workflow's
full-ciwent red, so the publish job skipped and nov2.47.0tag or GitHub Release was created. Both failures were wall-clock races in tests, not product bugs — they only surface underfull: true, which runs the whole suite rather than the impact-scoped subset the PR checks use.llamaServerManager— the brew-keg-link test flippedfindCommandOnPathon a 15 ms timer racing the install child's own 10 ms exit. On a loaded Windows runner the timer won, so the binary looked already-linked andbrew linknever ran (1 spawn call instead of 2). Now the flip is keyed off thelinkspawn, which is what actually puts the binary on PATH — deterministic, and still fails if the product stops linking.SongBookViewer— themmetronome shortcut is a window listener attached in an effect, butfindByLabelTextresolves on the DOM mutation, which can commit first. The keystroke landed on a page with no handler. Now the keystroke is retried until it lands. (The click-based metronome tests were never exposed: those are React prop handlers.)The
lintjob failure was a pure cascade — lint itself passed ("Checked 2142 files. No fixes applied"); the job only re-reports the client job's result.No product code changed.
package.jsonis already at 2.47.0 and nov2.47.0tag exists, so merging this re-runs the Release workflow, which auto-tags and publishes.Test plan
server && npx vitest run services/llamaServerManager.test.js— 18 passedclient && npx vitest run src/pages/SongBookViewer.test.jsx— 64 passed, 5 consecutive runs