Point the README examples at v0.15.0 - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README tells people to use
astronomer/deploy-action@v0.14.0, in 20 places. #161 has merged, so the next tag is v0.15.0 and the examples should point at it.Merge this and cut the v0.15.0 tag together. Until the tag exists, these examples reference a ref that does not resolve — which is how #157 and #158 went in July.
v0.15.0 carries one behaviour change worth naming in the release notes:
cli-versionnow defaults to1.45.0rather than empty. Empty meant the installer picked, which resolved to a hardcoded constant on astro-cli'smainand lagged real releases by anywhere from 9 minutes to 13 days. 1.45.0 is the version an unpinned run installs today, so nobody's CLI moves on upgrade — it is stated now rather than inferred, and it stays put until someone bumps it.Anyone who wants to track the newest CLI has no option in v0.15.0. That is a real gap, and the follow-up adds
cli-version: latestas an explicit opt-in. It needs astro-cli v1.46.0 first, since it reads theinstall.shasset that astronomer/astro-cli#2252 publishes and no released version carries one yet.🎟 Issue(s)
None.
🧪 Functional Testing
Docs only, and the diff is one string repeated. No
0.14.0references remain.📸 Screenshots
N/A.
📋 Checklist
make testbefore taking out of draft — no code changedmake lintbefore taking out of draft — no code changed@v0.14.0, so they need to move to@v0.15.0once tagged; nothing landing onmainreaches them before thatinstall.astronomer.io, which is unaffected