Repository navigation
Conversation
Sachanski
reviewed
Oct 26, 2026
| const namespacedKey = this.namespacedKey(key) | ||
| //we have to remove the marker as well or it will pass to the new url | ||
| keysToDelete.push(namespacedKey, this.validationKey(namespacedKey)) | ||
| } |
Collaborator
There was a problem hiding this comment.
This can be shortened a bit
const toDelete = keys.flatMap(k => {
const namespacedKey = this.namespacedKey(key)
return [namespacedKey, this.validationKey(namespacedKey)]
})
Sachanski
previously approved these changes
Oct 26, 2026
Sachanski
previously approved these changes
Oct 26, 2026
| async delete(key: string) { | ||
| await redis.del(this.namespacedKey(key)) | ||
| async delete(...keys: string[]) { | ||
| const toDelete = keys.flatMap((key) => { |
Collaborator
There was a problem hiding this comment.
Now we can change this to keys.flatMap((key) => [this.namespacedKey(key), this.validationKey(key)])
zmarinov-astea
approved these changes
Oct 27, 2026
Sachanski
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue: When an item is updated, new thumbnail is being generated and updated as an S3 object. However presigned URLS to S3 are being cached and are pointing to the old version of the thumbnail.
Example scenario: change an item of a tapestry, go to the dashboard without refresh - the old thumbnail before the changes is shown.
Fix: Invalidate the presigned URLs. After every change to S3 object, we delete the presigned URL from the cache so a new one must be generated.
Note: On the above test scenario, there is a slight delay to thumbnail change, until the worker generates the new thumbnail.