perf: invoke node directly from the js_binary launcher - #2972
Merged
Conversation
acozzette
marked this pull request as ready for review
August 14, 2026 02:17
jbedard
reviewed
Aug 14, 2026
Member
|
Make sure we have tests covering this scenario 👍 |
jbedard
approved these changes
Aug 14, 2026
The launcher ran the program through our Node wrapper script, which does nothing but pass its arguments along to Node and add a `--require` flag for our fs patches. Let's just inline that into our main launcher script so that we avoid spawning another bash process unnecessarily. We still need to keep the Node wrapper around, though, so that if we ever shell out to `node` then we get our wrapper with its patches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
acozzette
force-pushed
the
remove-extra-bash-process
branch
2 times, most recently
from
August 14, 2026 16:23
14d4bc0 to
a5ae0be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher ran the program through our Node wrapper script, which does nothing but pass its arguments along to Node and add a
--requireflag for our fs patches.Let's just inline that into our main launcher script so that we avoid spawning another bash process unnecessarily.
We still need to keep the Node wrapper around, though, so that if we ever shell out to
nodethen we get our wrapper with its patches.Changes are visible to end-users: no
Test plan