feat: allow proto_library as js_library#dep

[alexeagle]

Design:

• user expected to register a toolchain providing their protoc plugin for gen-es
• use an aspect to adapt ProtoInfo to JsInfo, so a proto_library target can appear anywhere a js_library does
• no need for js_proto_library targets to pollute the package where the proto_library appears
• similar to feat: allow proto_library as rb_library#dep bazel-contrib/rules_ruby#292

Example of use currently in aspect-build/rules_ts#894

TODO:

• for typescript, place .d.ts files in the source tree, with @kormide using diff.bzl as a validation action. Maybe this belongs in rules_ts
• support connect_query - we didn't have any test/example usage of it

[github-actions]

Summary

Status	Count
🔍 Total	159
✅ Successful	137
⏳ Timeouts	0
🔀 Redirected	17
👻 Excluded	0
❓ Unknown	0
🚫 Errors	5
⛔ Unsupported	0

Errors per input

Errors in docs/pnpm.md

• [429] https://blog.aspect.build/easier-merges-on-lockfiles | Rejected status code (this depends on your "accept" configuration): Too Many Requests

Errors in docs/README.md

• [429] https://blog.aspect.build/bazelrc-flags | Rejected status code (this depends on your "accept" configuration): Too Many Requests
• [429] https://blog.aspect.build/configuring-bazels-downloader | Rejected status code (this depends on your "accept" configuration): Too Many Requests

Errors in docs/troubleshooting.md

• [404] https://github.com/aspect-build/rules_jest/blob/main/docs/jest_test.md#jest_test-run_in_band | Rejected status code (this depends on your "accept" configuration): Not Found

Errors in README.md

• [429] https://blog.aspect.build/rulesjs-npm-benchmarks | Rejected status code (this depends on your "accept" configuration): Too Many Requests

Redirects per input

Redirects in docs/README.md

• [200] http://deno.land/ | Redirect: Followed 2 redirects resolving to the final status of: OK. Redirects: http://deno.land/ --> https://deno.land/ --> https://deno.com/
• [200] http://slack.bazel.build/ | Redirect: Followed 3 redirects resolving to the final status of: OK. Redirects: http://slack.bazel.build/ --> https://slack.bazel.build/ --> https://join.slack.com/t/bazelbuild/shared_invite/zt-3pvqsmus1-JyNX5nCX_s4K30CqBpWRCA --> https://bazelbuild.slack.com/join/shared_invite/zt-3pvqsmus1-JyNX5nCX_s4K30CqBpWRCA
• [200] http://typescriptlang.org/ | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: http://typescriptlang.org/ --> https://www.typescriptlang.org/
• [200] https://aspect.build/cli | Redirect: Followed 2 redirects resolving to the final status of: OK. Redirects: https://aspect.build/cli --> https://docs.aspect.build/cli --> https://docs.aspect.build/login?redirect=%2Fcli
• [200] https://bazel.build/rules/macros | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://bazel.build/rules/macros --> https://bazel.build/extending/macros
• [200] https://code.visualstudio.com/docs/editor/debugging | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://code.visualstudio.com/docs/editor/debugging --> https://code.visualstudio.com/docs/debugtest/debugging
• [200] https://docs.aspect.build/cli/commands/aspect_configure | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://docs.aspect.build/cli/commands/aspect_configure --> https://docs.aspect.build/login?redirect=%2Fcli%2Fcommands%2Faspect_configure
• [200] https://docs.aspect.build/guides/rules_js_migration | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://docs.aspect.build/guides/rules_js_migration --> https://docs.aspect.build/login?redirect=%2Fguides%2Frules_js_migration
• [200] https://docs.aspect.build/workflows | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://docs.aspect.build/workflows --> https://docs.aspect.build/login?redirect=%2Fworkflows

Redirects in docs/troubleshooting.md

• [200] https://bazelbuild.slack.com/archives/CA31HN1T3/p1733518986229749?thread_ts=1733516180.969159&cid=CA31HN1T3 | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://bazelbuild.slack.com/archives/CA31HN1T3/p1733518986229749?thread_ts=1733516180.969159&cid=CA31HN1T3 --> https://bazelbuild.slack.com/?redir=%2Farchives%2FCA31HN1T3%2Fp1733518986229749%3Fthread_ts%3D1733516180.969159%26cid%3DCA31HN1T3%26name%3DCA31HN1T3%26perma%3D1733518986229749

Redirects in README.md

• [200] http://github.com/bazelbuild/rules_nodejs | Redirect: Followed 2 redirects resolving to the final status of: OK. Redirects: http://github.com/bazelbuild/rules_nodejs --> https://github.com/bazelbuild/rules_nodejs --> https://github.com/bazel-contrib/rules_nodejs
• [200] http://typescriptlang.org/ | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: http://typescriptlang.org/ --> https://www.typescriptlang.org/
• [200] https://cypress.io/ | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://cypress.io/ --> https://www.cypress.io/
• [200] https://docs.aspect.build/rules | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://docs.aspect.build/rules --> https://docs.aspect.build/login?redirect=%2Frules
• [200] https://docs.aspect.build/workflows | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://docs.aspect.build/workflows --> https://docs.aspect.build/login?redirect=%2Fworkflows
• [200] https://github.com/bazelbuild/rules_nodejs | Redirect: Followed 1 redirect resolving to the final status of: OK. Redirects: https://github.com/bazelbuild/rules_nodejs --> https://github.com/bazel-contrib/rules_nodejs
• [200] https://slack.bazel.build/ | Redirect: Followed 2 redirects resolving to the final status of: OK. Redirects: https://slack.bazel.build/ --> https://join.slack.com/t/bazelbuild/shared_invite/zt-3pvqsmus1-JyNX5nCX_s4K30CqBpWRCA --> https://bazelbuild.slack.com/join/shared_invite/zt-3pvqsmus1-JyNX5nCX_s4K30CqBpWRCA
  Full Github Actions output

[alexeagle]

@dzbarsky should we drop this in contrib_toolchains ?

[aspect-workflows]

Bazel 7 (Test)

Buildkite build #12135 is running...

---

Bazel 8 (Test)

All tests were cache hits

275 tests (100.0%) were fully cached saving 37s.

---

Bazel 9 (Test)

All tests were cache hits

275 tests (100.0%) were fully cached saving 35s.

---

Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 634ms.

---

Bazel 8 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 819ms.

---

Bazel 9 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 701ms.

---

Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 8 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 23ms.

---

Bazel 9 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 149ms.

---

Bazel 8 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 53ms.

---

Bazel 9 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 84ms.

---

Bazel 7 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

---

Bazel 8 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 37ms.

---

Bazel 9 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

---

Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

---

Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 227ms.

---

Bazel 8 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 266ms.

---

Bazel 9 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 202ms.

---

Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 269ms.

---

Bazel 8 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 625ms.

---

Bazel 9 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 248ms.

---

Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 251ms.

---

Bazel 8 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 230ms.

---

Bazel 9 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 231ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 701ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 416ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 455ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 268ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 132ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 123ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 105ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 33ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 40ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 86ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 106ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_multi

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 113ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 28ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 38ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 393ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 385ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 424ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 94ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

---

Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 9 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 9 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 224ms.

---

Bazel 8 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 275ms.

---

Bazel 9 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 312ms.

---

Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

37 tests (100.0%) were fully cached saving 4s.

---

Bazel 8 (Test)

e2e/pnpm_lockfiles

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

11 tests (100.0%) were fully cached saving 1s.

---

Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 840ms.

---

Bazel 8 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.

---

Bazel 9 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.

---

Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 56ms.

---

Bazel 8 (Test)

e2e/pnpm_version

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 58ms.

---

Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

---

Bazel 8 (Test)

e2e/pnpm_workspace

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

---

Bazel 9 (Test)

e2e/pnpm_workspace

All tests were cache hits

14 tests (100.0%) were fully cached saving 3s.

---

Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 355ms.

---

Bazel 8 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 384ms.

---

Bazel 9 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 410ms.

---

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12135 is running...

---

Bazel 8 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

---

Bazel 7 (Test)

e2e/repo_mapping

Buildkite build #12135 is running...

---

Bazel 8 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 212ms.

---

Bazel 9 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 333ms.

---

Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 179ms.

---

Bazel 8 (Test)

e2e/runfiles

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/runfiles

Buildkite build #12135 is running...

---

Bazel 7 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 48ms.

---

Bazel 8 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 39ms.

---

Bazel 9 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 130ms.

---

Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 126ms.

---

Bazel 8 (Test)

e2e/vendored_node

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/vendored_node

Buildkite build #12135 is running...

---

Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/vendored_tarfile

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/vendored_tarfile

Buildkite build #12135 is running...

---

Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 92ms.

---

Bazel 8 (Test)

e2e/verify_patches

Buildkite build #12135 is running...

---

Bazel 9 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 120ms.

---

Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 75ms.

---

Bazel 8 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

---

Bazel 9 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 92ms.

---

Buildifier      Format

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5210cdb3d7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[jbedard]

If this is the direction other rulesets such as ruby then I definitely think we should do the same.

It might be nice to land this for the v3 release, which I thought was basically ready to go until seeing this...

[dzbarsky]

github changed how comments work, i keep forgetting to submit now...