Support opening bare repositories - #94
Open
mjc wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This lets
guitaropen bare repositories for history browsing without a working tree. Repository loads now derive worktree capability from the currently openedgit2::Repository, so reloading or switching repositories cannot leave stale bare/worktree state behind.The same change keeps workdir status collection on libgit2's recursive status entries, rather than expanding untracked directories through filesystem paths and re-querying each child. That avoids path re-resolution problems on case-insensitive filesystems when a repo contains case-colliding filenames from another platform.
A better way to do this in the future would be to move toward more of a state machine than a bunch of bools.
Details
Command::required_capability()and current repository worktree support.Details
Command::required_capability()and current repository worktree support.Tests
cargo test bare_repo -- --nocapturecargo test unavailable_worktree_blocks_worktree_commands_before_dispatch -- --nocapturecargo test reload_refreshes_worktree_state_for_new_repository -- --nocapturecargo test workdir_diff -- --nocapture