fix(nextjs): null user/organization while signed out and ID token fallback without profile fetching - #563
Open
DonOmalVindula wants to merge 1 commit into
Conversation
…lback without profile fetching AsgardeoProvider initialised `user` and `currentOrganization` with empty objects, so `<User fallback>` / `<Organization fallback>` never rendered their fallbacks and OrganizationSwitcher offered to manage an organization with an empty ID. With `preferences.user.fetchUserProfile: false` the user stayed empty, whereas the React SDK falls back to the ID token claims. - Default both to null, as the React SDK does. - Populate the user and profile from the ID token claims when profile fetching is disabled. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AsgardeoServerProviderinitialiseduserwith{}andcurrentOrganizationwith{id: '', name: '', orgHandle: ''}. Both are truthy, so<User fallback={...}>and<Organization fallback={...}>never rendered their fallbacks while signed out,useAsgardeo().usercould not be checked for truthiness, and<OrganizationSwitcher />showed a "manage organization" entry for an organization with an empty ID whenever the organization lookup failed. The React SDK keeps bothnulluntil they are known.preferences.user.fetchUserProfile: falsethe Next.js provider left the user and profile empty; the React SDK falls back to the claims of the ID token.Fix
userandcurrentOrganizationdefault tonull(the client provider prop type follows).extractUserClaimsFromIdToken), mirroring the React SDK.Testing
pnpm lint,tsc --noEmitandpnpm vitest run(60 tests) for@asgardeo/nextjs. The provider change is covered by review; there is no component test setup in this package.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code