fix(nextjs): keep the profile on screen when a profile update fails - #557
Open
DonOmalVindula wants to merge 1 commit into
Open
fix(nextjs): keep the profile on screen when a profile update fails#557DonOmalVindula wants to merge 1 commit into
DonOmalVindula wants to merge 1 commit into
Conversation
updateUserProfileAction reports failures as a result instead of throwing, and UserProfile handed the empty user of that result to onUpdateProfile, which replaced the displayed profile with an empty one and showed no message. - Show the failure reason through BaseUserProfile's error alert, as the React SDK does, and leave the profile untouched. - Forward the component-level `preferences` to the base component. - Return the underlying error message from the action (it said "Failed to get user profile"). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateUserProfileActionreports a failed update as{success: false, error, data: {user: {}}}rather than throwing.<UserProfile />ignoredsuccessand passedresult.data.usertoonUpdateProfileunconditionally, so a rejected update (read-only attribute, expired token, network error) replaced the displayed profile with an empty one and showed nothing. The React SDK keeps the profile and shows the error throughBaseUserProfile'serrorprop.Fix
UserProfilechecks the result: on failure it keeps the profile and shows the reason (or the genericuser.profile.update.generic.errortext) in the profile's error alert; on success it updates the context as before. Errors thrown by the action call are handled the same way.preferencesprop (i18n / theme) is now forwarded toBaseUserProfile, as in the React SDK.updateUserProfileActionreturns the underlying error message; it used to prefix it with "Failed to get user profile".Testing
updateUserProfileActionunit tests for the success and failure results (62 tests pass).pnpm lintandtsc --noEmitfor@asgardeo/nextjs. There is no component test setup in this package, so the component change is covered by review.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code