fix(nextjs): apply signInOptions to the redirect-based sign-in - #555
Open
DonOmalVindula wants to merge 1 commit into
Open
fix(nextjs): apply signInOptions to the redirect-based sign-in#555DonOmalVindula wants to merge 1 commit into
DonOmalVindula wants to merge 1 commit into
Conversation
The signInOptions configured on AsgardeoProvider were never appended to the authorize request, and passing signInOptions to SignInButton made the click fail: signInAction treated any non-empty payload as an embedded-flow step and handed it to the legacy client, which rejected it for lack of a callback. - signInAction only treats a payload with a flowId as an embedded-flow step; everything else resolves the redirect-based sign-in URL with the configured signInOptions and the caller's options appended. - SignInButton tracks its loading state and passes signIn / isLoading to render-prop children, like the React SDK. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
signInOptionsconfigured on<AsgardeoProvider>(for example{fidp: 'OrganizationSSO'}or{prompt: 'login'}) were never applied:signInActionbuilt the authorize URL withgetAuthorizeRequestUrl({}, sessionId), and the legacy Node client does not readsignInOptionsfrom the configuration by itself. The React SDK appends them.<SignInButton signInOptions={{prompt: 'login'}}>failed on click: the action treated any non-empty payload as an embedded-flow step,AsgardeoNextClient.signIn()then called the legacysignInwithout a callback, and the click ended inNODE-AUTH_CORE-SI-NF02 Invalid AuthURLCallback function.SignInButtonreceivedsignInandisLoadingasundefined, and the JSDoc told users to rely ontype="submit", which does nothing here.Fix
signInActiononly treats a payload with aflowIdas an embedded-flow step. Anything else resolves the redirect-based sign-in URL with{...config.signInOptions, ...options}appended to the authorize request.SignInButtontracks its loading state and passessignIn/isLoadingtoBaseSignInButton, so render props work as in the React SDK. Its docs showsignInOptionsand the render-prop usage.Testing
signInActionunit tests: no payload, empty payload, caller options merged over configured options, no configured options, an embedded-flow step, and reuse of an existing temporary session (66 tests pass).pnpm lintandtsc --noEmitfor@asgardeo/nextjs.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code