fix(react): focus the dialog on open instead of the hidden trigger - #546
Closed
DonOmalVindula wants to merge 1 commit into
Closed
fix(react): focus the dialog on open instead of the hidden trigger#546DonOmalVindula wants to merge 1 commit into
DonOmalVindula wants to merge 1 commit into
Conversation
…n the hidden trigger
FloatingFocusManager marks everything outside an open dialog aria-hidden. With
initialFocus={-1} the focus stayed on the element that opened the dialog, e.g.
the user dropdown trigger in a page header, so a focused element was hidden
from assistive technology and Chrome logged "Blocked aria-hidden on an element
because its descendant retained focus" whenever the profile popup opened.
Focus the dialog container itself on open. This keeps the previous behaviour of
not auto-focusing the first input.
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Contributor
Author
|
Folded into #545 so both fixes ship with a single changeset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Opening the profile popup from the user dropdown logged a browser accessibility error: "Blocked aria-hidden on an element because its descendant retained focus".
Cause
The dialog's
FloatingFocusManagermarks everything outside the dialogaria-hidden, butinitialFocus={-1}left focus on the trigger button inside the now-hidden page header.Change
Focus the dialog container itself when it opens (
initialFocus={context.refs.floating}plustabIndex={-1}on the content). The first input is still not auto-focused.Testing