Fix issue #204 (asdf/core metadata order in the tree)#209
Merged
Conversation
Reverse iterators for mappings needed for asdf-formatgh-204, but add for sequences and generic container iterators as well.
Could have probably done this a number of different ways, but simplest overall change was to keep using asdf_mapping_update but add _ex version that prepends new keys at the beginning of the mapping rather than appending them, so asdf_mapping_reverse_iter is needed to prepend keys while keeping their original order. asdf-formatgh-204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly resolves #204 .
Found it useful to be able to reverse iterate mapping, so also added new APIs
asdf_mapping_reverse_iter_init,asdf_mapping_sequence_iter_init, andasdf_mapping_container_iter_init. No other new iter functions are needed; the iteration order is stored on the iterator handle.