fix: time format validation only applies to strings#207
Merged
Conversation
For values in decimal formats the time format is ambiguous and should not be guessed. Likewise, according the the actual schema, the string formats are only valid in the schema if they are guessable, basically (i.e. 'J2000.0', not just '2000.0', even if `format: jyear` is specified. Follow-up to asdf-format#205 which intended to fix this as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For values in decimal formats the time format is ambiguous and should not be guessed. Likewise, according the the actual schema, the string formats are only valid in the schema if they are guessable, basically (i.e. 'J2000.0', not just '2000.0', even if
format: jyearis specified.Follow-up to #205 which intended to fix this as well.