Repository navigation
Add TaggedExtensionLabel for tagged-extension keys - #865
Open
danieleggert wants to merge 1 commit into
Open
danieleggert wants to merge 1 commit into
danieleggert wants to merge 1 commit into
Conversation
This was referenced Oct 12, 2026
danieleggert
force-pushed
the
harden-3-tagged-ext-label
branch
from
October 24, 2026 09:37
fea32f3 to
2e53560
Compare
danieleggert
marked this pull request as ready for review
October 24, 2026 09:39
mdiep
reviewed
Oct 28, 2026
danieleggert
force-pushed
the
harden-3-tagged-ext-label
branch
from
October 29, 2026 15:26
2e53560 to
20e5b9d
Compare
danieleggert
force-pushed
the
harden-3-tagged-ext-label
branch
from
October 30, 2026 14:42
20e5b9d to
2220077
Compare
Generic over the extended type, so a STORE key can't be used where a FETCH key is expected.
danieleggert
force-pushed
the
harden-3-tagged-ext-label
branch
from
October 30, 2026 14:48
2220077 to
1d94b70
Compare
mdiep
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3/6] One of the design goals of this library is that the API types can only represent valid state. But that doesn’t hold true today. These 6 stacked PRs are smaller steps towards that goal. #863 #864 #865 #866 #867 #868
Motivation:
RFC 4466
tagged-ext-labelkeys wereStrings written raw.Modifications:
TaggedExtensionLabelreplaces them; literals compile unchanged. Case-insensitive per RFC 4466, so(foo 1 FOO 2)parses as one entry.