Conditionally conform Chain2Sequence to MutableCollection - #283
Open
shubhransh-gupta wants to merge 1 commit into
Open
Conditionally conform Chain2Sequence to MutableCollection#283shubhransh-gupta wants to merge 1 commit into
shubhransh-gupta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #217.
Adds conditional conformance of
Chain2SequencetoMutableCollectionwhen both underlying base sequences (Base1andBase2) conform toMutableCollection.Motivation
When chaining two mutable collections (e.g.
[1, 2, 3]and[4, 5, 6]), users expect to be able to mutate elements in-place via indices or subscripts without converting the chained sequence into an intermediate array or losing lazy execution benefits.Changes
Sources/Algorithms/Chain.swift:base1andbase2inChain2Sequencefromlettovar.extension Chain2Sequence: MutableCollection where Base1: MutableCollection, Base2: MutableCollection.subscript(i: Index)withget,set, and_modify(usingyield &base1[i]/yield &base2[i]for efficient in-place mutation).Guides/Chain.md:MutableCollectionamong the conditional conformances.Tests/SwiftAlgorithmsTests/ChainTests.swift:testChainMutableCollection()verifying index mutations across both chained collections.Verification
swift build— builds cleanly with 0 errors.