feat(viewer): add controlled selection highlight - #232
Draft
LucaVor wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
selection?: DataPointID[] | nullprop to the high-levelEmbeddingAtlasAPInull/undefinedWhy
The dashboard already has an internal point-highlight store, but the high-level viewer API did not expose a controlled input. Embedders therefore could not mirror an external selection into the embedding and instances views without reaching through private internals.
Validation
npm run test -w @embedding-atlas/viewer— 3 files / 36 tests passedgit diff --check— passedThe repository's canonical GitHub Actions workflow will run its full Rust/WASM build, workspace type checks, complete tests, formatting, and Clippy. This is opened as a draft pending that result.