Skip to content

test: unskip Graph CoreML export tests as segfault no longer occurs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guru-desh merged 1 commit into from
Jul 14, 2026
Merged

test: unskip Graph CoreML export tests as segfault no longer occurs #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions tests/export/test_pt2e_mil_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
for qscheme in QuantizationScheme
]
+ [
# uint8 asymmetric per-tensor - crashes with segfault
# uint8 weights with per-tensor granularity, asymmetric qscheme
(
torch.uint8,
PerTensorGranularity(),
Expand All @@ -102,22 +102,9 @@
_test_params_with_xfail: list = []
for params in _test_params:
dtype, wg, ag, qscheme = params
# uint8 asymmetric per-tensor crashes with segfault
if (
dtype == torch.uint8
and isinstance(wg, PerTensorGranularity)
and isinstance(ag, PerTensorGranularity)
and qscheme == QuantizationScheme.ASYMMETRIC
):
_test_params_with_xfail.append(
pytest.param(
*params,
marks=pytest.mark.skip(reason="Crashes with segfault"),
),
)
# Per-channel activation with negative axis has SNR below threshold.
# TODO: SNR below threshold for per-channel activation with negative axis on CoreML export.
elif isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0:
if isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0:
_test_params_with_xfail.append(
pytest.param(
*params,
Expand Down