Repository navigation
fix(chart): include semantic views in datasource filter - #46021
Open
mikebridge wants to merge 2 commits into
Open
mikebridge wants to merge 2 commits into
mikebridge wants to merge 2 commits into
Conversation
github-actions
Bot
added
api
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #46021 +/- ##
=======================================
Coverage 85.00% 85.01%
=======================================
Files 3080 3080
Lines 209252 209278 +26
Branches 49292 49300 +8
=======================================
+ Hits 177881 177910 +29
+ Misses 27990 27986 -4
- Partials 3381 3382 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mikebridge
marked this pull request as ready for review
November 5, 2026 02:09
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
Comment on lines
+859
to
862
| operator: isFeatureEnabled(FeatureFlag.SemanticLayers) | ||
| ? FilterOperator.ChartDatasource | ||
| : FilterOperator.Equals, | ||
| unfilteredLabel: t('All'), |
Contributor
There was a problem hiding this comment.
Suggestion: With Semantic Layers enabled, saved URLs still pass numeric datasource_id values; ChartDatasourceFilter rejects them, so bookmarked dataset filters return no charts.
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes · 🏷️ Api mismatch
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** superset-frontend/src/pages/ChartList/index.tsx
**Line:** 859:862
**Comment:**
*Api Mismatch: With Semantic Layers enabled, saved URLs still pass numeric `datasource_id` values; `ChartDatasourceFilter` rejects them, so bookmarked dataset filters return no charts.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
TL;DR: The Charts list Datasource filter includes semantic views when Semantic Layers is enabled, and selecting a view shows only charts built from that view.
Background: The Charts list already displays and links semantic views in its Datasource column.
Problem: The filter loaded options only from the dataset endpoint. A semantic view could not be found by name, and a numeric datasource ID alone could not distinguish a view from a dataset with the same ID.
Changes: With Semantic Layers enabled, the filter uses the combined datasource list and labels dataset and semantic-view options separately. The selected value includes both datasource type and ID; an additive chart-list search operator matches both. Invalid typed values return no charts. With Semantic Layers disabled, the existing dataset endpoint and numeric equality filter remain in use. The user guide documents the expanded filter.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not included; the filter options and request are covered by RTL tests.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
SEMANTIC_LAYERSfor semantic-view options