Repository navigation
fix(databricks): restore the dynamic connection form - #45989
Open
mikebridge wants to merge 5 commits into
Open
mikebridge wants to merge 5 commits into
mikebridge wants to merge 5 commits into
Conversation
Preserve the native connection form, legacy URI compatibility, and historical Databricks denylist entries.
1 of 9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45989 +/- ##
=======================================
Coverage 84.93% 84.93%
=======================================
Files 3077 3077
Lines 208205 208207 +2
Branches 49105 49105
=======================================
+ Hits 176834 176836 +2
Misses 28002 28002
Partials 3369 3369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mikebridge
marked this pull request as ready for review
November 3, 2026 19:56
Contributor
aminghadersohi
self-requested a review
November 3, 2026 21:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft carries #45911 by @Vitor-Avila forward while he is away. It merges master after #45843 and preserves both the Databricks dynamic form and the legacy-URI migration. The production-code conflict was the driver map:
databricksremains the native default, whiledatabricks-sql-pythonremains a saved-URI compatibility alias. The original summary below predates #45843; its statement that connection migration is follow-up work no longer applies because #45843 is in master. ExistingDBS_AVAILABLE_DENYLISTentries using the old driver name continue to hide this option.SUMMARY
The official
databricks-sqlalchemydialect reports its driver asdatabricks, but Superset advertisesdatabricks-sql-python. The available-databases API only includes dynamic-form parameters when the spec's default driver is installed, so this mismatch omits the form schema.Update the Python connector's default driver and driver mapping to
databricks. This PR is limited to restoring the connection form; legacy-driver removal and connection migration are follow-up work.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: with the official dialect installed, the Databricks connection form can appear blank because its parameters are missing from the API response.
After: the registered driver matches the spec, allowing the API to include the dynamic-form parameters.
TESTING INSTRUCTIONS
databricks-sqlalchemy2.x./api/v1/database/available/should includedefault_driver: "databricks"andparameters.Local validation: pre-commit passed; 61 focused Databricks, multi-cloud, and engine-discovery unit tests passed. OAuth and installed-dialect SQL-rendering tests were excluded because unrelated failures were also reproduced on the unchanged base. Live UI validation was not performed because the local server was not running.
ADDITIONAL INFORMATION
REPLACEMENT VALIDATION AND OPEN FEEDBACK
databricks-sql-pythonas a denylist alias for the renamed default. The red-first test failed for the old name before the fix and passed for both names afterward. NoUPDATING.mdentry is needed because old configuration keeps working.databricks-sqlalchemy2.x. Its dialect registration and dialect both usedatabricks;databricks-sql-pythonis retained for saved-URI lookup, not emitted as an installed driver by that package. A legacy-only installed-driver set is outside the supported extra.tests/unit_tests/models/core_test.py, whose code and test are unchanged from master. Live UI validation was not run.