Repository navigation
fix(packaging): declare CLI dependency and document matched-core source installs - #45938
Open
alberttwong wants to merge 1 commit into
Open
alberttwong wants to merge 1 commit into
alberttwong wants to merge 1 commit into
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45938 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 3072 3072
Lines 206119 206119
Branches 48539 48539
=======================================
Hits 174718 174718
Misses 28101 28101
Partials 3300 3300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
A fresh source install can select an older published
apache-superset-corewith incompatible SQLAlchemy requirements, and the CLI importsricheven though package metadata does not declare it. Declarerichdirectly and document installing the application and core together from the same checkout, including the editable development command.Refs #45937 and #42568. This addresses the Superset packaging portion of #45937; it does not close the broader Flight SQL compatibility report. Table/type reflection fixes belong to the third-party adapter and are being submitted separately. The
richdeclaration also overlaps the broader, still-open Python 3.15 work in #45823; this PR offers the small independently validated packaging fix.No core version bound is invented before a matching package is published. The source-install command uses the matching local core without bypassing dependency resolution.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; dependency metadata and documentation only.
TESTING INSTRUCTIONS
Validated on Python 3.12.16, macOS arm64, against master
7519fa8b6f5a145097d51e36579240e872044266:python -m pip install /path/to/superset /path/to/superset/superset-core(plus pytest, pre-commit and build as validation tools).rich==15.0.0was installed through application metadata, without an explicit rich install.python -m pip check: no broken requirements.superset --helpsucceeds with disposable local configuration.superset db upgradeagainst a fresh isolated SQLite metadata database succeeds./health: HTTP 200.pre-commit runon all three staged files: all applicable checks passed.git diff --check: passed.Reproduce with a clean Python 3.12 environment, the documented source-install command, and a disposable Superset configuration. No existing metadata or running deployment needs changing.
Separately, the adapter fix was exercised with Superset 7.0.0rc2 against a disposable Redis Arrow Flight SQL endpoint: table discovery, BIGINT/VARCHAR/FLOAT column reflection, ordered/NULL/empty reads, SQL Lab CREATE/INSERT/UPDATE/DELETE/DROP with read-back assertions, dataset creation, and a grouped chart data query passed. Browser rendering and production behavior remain unverified.
ADDITIONAL INFORMATION