Skip to content

[SPARK-58975][CORE] Add failure messages to MemoryPool require checks #58251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uros-b wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[SPARK-58975][CORE] Add failure messages to MemoryPool require checks #58251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ff2998
[SPARK-58975][CORE] Add failure messages to MemoryPool require checks
uros-b Aug 24, 2026
58aa80b
Merge branch 'apache:master' into memorypool-require-messages
uros-b Aug 25, 2026
90a3b70
Merge branch 'apache:master' into memorypool-require-messages
uros-b Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/src/main/scala/org/apache/spark/memory/MemoryPool.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,20 @@ private[memory] abstract class MemoryPool(lock: Object) {
* Expands the pool by `delta` bytes.
*/
final def incrementPoolSize(delta: Long): Unit = lock.synchronized {
require(delta >= 0)
require(delta >= 0, s"cannot increment the pool size by a negative amount: $delta")
_poolSize += delta
}

/**
* Shrinks the pool by `delta` bytes.
*/
final def decrementPoolSize(delta: Long): Unit = lock.synchronized {
require(delta >= 0)
require(delta <= _poolSize)
require(_poolSize - delta >= memoryUsed)
require(delta >= 0, s"cannot decrement the pool size by a negative amount: $delta")
require(delta <= _poolSize,
s"cannot decrement the pool size ${_poolSize} by a larger amount: $delta")
require(_poolSize - delta >= memoryUsed,
s"cannot decrement the pool size ${_poolSize} by $delta because the used memory " +
s"$memoryUsed would exceed the remaining pool size")
_poolSize -= delta
}

Expand Down