fix: release inbound MqttPublishMessage payload ByteBuf and retain per subscriber write - #6977
Open
wy471x wants to merge 1 commit into
Conversation
…r subscriber write The inbound MqttPublishMessage payload ByteBuf was never released, leaking a native/pooled buffer on every PUBLISH. Fan-out to multiple subscriber channels also wrote the same ByteBuf without retaining it. Release the inbound message in channelRead, retain the payload across the asynchronous send, and use retainedDuplicate for each subscriber. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inbound MqttPublishMessage payload ByteBuf was never released, leaking a native/pooled buffer on every PUBLISH. Fan-out to multiple subscriber channels also wrote the same ByteBuf without retaining it.
Release the inbound message in channelRead, retain the payload across the asynchronous send, and use retainedDuplicate for each subscriber.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.Summary
Problems
ReferenceCountUtil.release(msg). The MqttPublishMessage payload ByteBuf leaked on every PUBLISH.
subscriber channel in parallel without a per-write retain — risking IllegalReferenceCountException or buffer corruption, and leaking after the first release.
Changes
returns.
Tests
close #6639