fix: Fix scale rule cache eviction by using rule ids(#6972) - #6975
Open
juicewcode wants to merge 1 commit into
Open
fix: Fix scale rule cache eviction by using rule ids(#6972)#6975juicewcode wants to merge 1 commit into
juicewcode wants to merge 1 commit into
Conversation
- Add cache eviction by database primary key. - Keep metric names as cache keys. - Add scale rule deletion to remove entries by rule ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6972
Fix scale rule cache eviction when rules are deleted.
ScaleRuleCachestores rules usingmetricNameas the map key:ruleCache.put(rule.getMetricName(), rule);However, ScaleRuleServiceImpl.delete receives database primary keys and passes them directly to the cache removal method:
scaleRuleCache.removeRulesFromCache(ids);The database deletion uses the same values as primary keys:
DELETE FROM scale_rule WHERE id IN (...)Because rule IDs and metric names are different fields, the deleted rule may remain in the in-memory cache.
Changes
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.