Skip to content

fix: avoid per-request String.format in context decorators (#6805) #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yykaue wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

fix: avoid per-request String.format in context decorators (#6805) #6969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601b314
fix: precompute default modules in context decorators
yykaue Aug 22, 2026
fca5449
Merge branch 'master' into fix-6805-context-decorator-format
yykaue Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...e/src/main/java/org/apache/shenyu/plugin/divide/context/DivideShenyuContextDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@
*/
public class DivideShenyuContextDecorator implements ShenyuContextDecorator {

private static final String DEFAULT_MODULE = PluginEnum.DIVIDE.getName() + "-" + RpcTypeEnum.HTTP.getName();

@Override
public ShenyuContext decorator(final ShenyuContext shenyuContext, final MetaData metaData) {
String path = shenyuContext.getPath();
shenyuContext.setMethod(path);
shenyuContext.setRealUrl(path);
shenyuContext.setRpcType(RpcTypeEnum.HTTP.getName());
shenyuContext.setModule(Optional.ofNullable(metaData).map(MetaData::getAppName)
.orElse(String.format("%s-%s", PluginEnum.DIVIDE.getName(), shenyuContext.getRpcType())));
.orElse(DEFAULT_MODULE));
return shenyuContext;
}
}
2 changes: 2 additions & 0 deletions ...c/test/java/org/apache/shenyu/plugin/divide/context/DivideShenyuContextDecoratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import org.apache.shenyu.common.dto.MetaData;
import org.apache.shenyu.plugin.api.context.ShenyuContext;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
Expand Down Expand Up @@ -54,5 +55,6 @@ public void decoratorTest() {
ShenyuContext decorator = divideShenyuContextDecorator.decorator(shenyuContext, metaData);
assert MOCK_CONTEXT_PATH.equals(decorator.getMethod());
assert MOCK_CONTEXT_PATH.equals(decorator.getRealUrl());
Assertions.assertEquals("divide-http", decorator.getModule());
}
}
4 changes: 3 additions & 1 deletion ...main/java/org/apache/shenyu/plugin/websocket/context/WebSocketShenyuContextDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
* The type WebSocket shenyu context decorator.
*/
public class WebSocketShenyuContextDecorator implements ShenyuContextDecorator {

private static final String DEFAULT_MODULE = PluginEnum.WEB_SOCKET.getName() + "-" + RpcTypeEnum.WEB_SOCKET.getName();

@Override
public ShenyuContext decorator(final ShenyuContext shenyuContext, final MetaData metaData) {
Expand All @@ -37,7 +39,7 @@ public ShenyuContext decorator(final ShenyuContext shenyuContext, final MetaData
shenyuContext.setRealUrl(path);
shenyuContext.setRpcType(RpcTypeEnum.WEB_SOCKET.getName());
shenyuContext.setModule(Optional.ofNullable(metaData).map(MetaData::getAppName)
.orElse(String.format("%s-%s", PluginEnum.WEB_SOCKET.getName(), shenyuContext.getRpcType())));
.orElse(DEFAULT_MODULE));
return shenyuContext;
}

Expand Down
Loading