Skip to content

[ISSUE #6855] fix: default RequestTemplate path to empty string #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yykaue wants to merge 3 commits into
base: master
Choose a base branch
from
+33 −1
Open

[ISSUE #6855] fix: default RequestTemplate path to empty string #6954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3613c1
fix: initialize RequestTemplate path field and add test coverage for …
yykaue Aug 20, 2026
7f1cd09
Merge branch 'master' into fix-6855-request-template-null-path
yykaue Aug 22, 2026
6163e5c
Merge branch 'master' into fix-6855-request-template-null-path
yykaue Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-sdk/shenyu-sdk-core/src/main/java/org/apache/shenyu/sdk/core/common/RequestTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public final class RequestTemplate {

private String contextId;

private String path;
private String path = "";

private ShenyuRequest.HttpMethod httpMethod;

Expand Down
11 changes: 11 additions & 0 deletions .../shenyu-sdk-core/src/test/java/org/apache/shenyu/sdk/core/common/RequestTemplateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ public void testRequest() {
Assert.assertNotNull(shenyuRequest);
}

@Test
public void testRequestWithoutPath() {
RequestTemplate template = new RequestTemplate();
template.setUrl("http://gateway");
template.setHttpMethod(ShenyuRequest.HttpMethod.GET);

ShenyuRequest shenyuRequest = template.request();

Assert.assertEquals("http://gateway", shenyuRequest.getUrl());
}

public void assertNotNull(final RequestTemplate requestTemplate) {
Assert.assertNotNull(requestTemplate);
Assert.assertNotNull(requestTemplate.getReturnType());
Expand Down
21 changes: 21 additions & 0 deletions ...-sdk-spring/src/test/java/org/apache/shenyu/sdk/spring/support/SpringMvcContractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ public class SpringMvcContractTest {

private static final Method DEL;

private static final Method HEALTH;

static {
try {
FIND_BY_ID = InvocationClient.class.getDeclaredMethod("findById", String.class);
INSERT = InvocationClient.class.getDeclaredMethod("insert", MetaData.class);
UPDATE = InvocationClient.class.getDeclaredMethod("update", MetaData.class);
DEL = InvocationClient.class.getDeclaredMethod("del", String.class);
HEALTH = InvocationClient.class.getDeclaredMethod("health");
} catch (NoSuchMethodException e) {
throw new RuntimeException(e);
}
Expand Down Expand Up @@ -95,6 +98,17 @@ public void parseRequestTplTest() {
assertEquals(template.getHttpMethod(), ShenyuRequest.HttpMethod.DELETE);
}

@Test
public void parseRootMappingRequestTemplateTest() {
SpringMvcContract contract = new SpringMvcContract();

RequestTemplate template = contract.parseRequestTemplate(HEALTH, bean);

assertSame(template.getMethod(), HEALTH);
assertEquals("", template.getPath());
assertEquals(ShenyuRequest.HttpMethod.GET, template.getHttpMethod());
}

@ShenyuClient(value = "invocationClient", path = "/dev/null")
public interface InvocationClient {

Expand Down Expand Up @@ -129,6 +143,13 @@ public interface InvocationClient {
*/
@DeleteMapping("/delete")
int del(@RequestParam("id") String id);

/**
* health check mapping.
* @return status
*/
@GetMapping
String health();
}

}
Loading