fix: add null-safety checks for labels and services in K8s RPC ingress parsers

shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DubboIngressParser.java

@@ -238,8 +238,16 @@ private List<IngressConfiguration> parseIngressRule(final V1IngressRule ingressR
                     SelectorData selectorData = createSelectorData(pathPath, conditionList, upstreamList);
                     List<RuleData> ruleDataList = new ArrayList<>();
                     List<MetaData> metaDataList = new ArrayList<>();
+                    if (Objects.isNull(labels) || labels.isEmpty()) {
+                        continue;
+                    }
                     for (String label : labels.keySet()) {
-                        Map<String, String> metadataAnnotations = serviceLister.namespace(namespace).get(labels.get(label)).getMetadata().getAnnotations();
+                        V1Service service = serviceLister.namespace(namespace).get(labels.get(label));
+                        if (Objects.isNull(service) || Objects.isNull(service.getMetadata())) {
+                            LOG.warn("Service {} not found in namespace {}", labels.get(label), namespace);
+                            continue;
+                        }
+                        Map<String, String> metadataAnnotations = service.getMetadata().getAnnotations();
                         DubboRuleHandle ruleHandle = createDubboRuleHandle(annotations);
                         List<ConditionData> ruleConditionList = getRuleConditionList(metadataAnnotations);
                         RuleData ruleData = createRuleData(metadataAnnotations, ruleHandle, ruleConditionList);

shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/GrpcParser.java

@@ -252,8 +252,16 @@ private List<IngressConfiguration> parseIngressRule(final V1IngressRule ingressR
                     SelectorData selectorData = createSelectorData(pathPath, conditionList, grpcUpstreamList);
                     List<RuleData> ruleDataList = new ArrayList<>();
                     List<MetaData> metaDataList = new ArrayList<>();
+                    if (Objects.isNull(labels) || labels.isEmpty()) {
+                        continue;
+                    }
                     for (String label : labels.keySet()) {
-                        Map<String, String> metadataAnnotations = serviceLister.namespace(namespace).get(labels.get(label)).getMetadata().getAnnotations();
+                        V1Service service = serviceLister.namespace(namespace).get(labels.get(label));
+                        if (Objects.isNull(service) || Objects.isNull(service.getMetadata())) {
+                            LOG.warn("Service {} not found in namespace {}", labels.get(label), namespace);
+                            continue;
+                        }
+                        Map<String, String> metadataAnnotations = service.getMetadata().getAnnotations();
                         List<ConditionData> ruleConditionList = getRuleConditionList(metadataAnnotations);
                         RuleData ruleData = createRuleData(metadataAnnotations, ruleConditionList, annotations);
                         MetaData metaData = parseMetaData(metadataAnnotations);

shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/SofaParser.java

@@ -169,8 +169,16 @@ private List<IngressConfiguration> parseIngressRule(final V1IngressRule ingressR
                     SelectorData selectorData = createSelectorData(path.getPath(), conditionList);
                     List<RuleData> ruleDataList = new ArrayList<>();
                     List<MetaData> metaDataList = new ArrayList<>();
+                    if (Objects.isNull(labels) || labels.isEmpty()) {
+                        continue;
+                    }
                     for (String label : labels.keySet()) {
-                        Map<String, String> metadataAnnotations = serviceLister.namespace(namespace).get(labels.get(label)).getMetadata().getAnnotations();
+                        V1Service service = serviceLister.namespace(namespace).get(labels.get(label));
+                        if (Objects.isNull(service) || Objects.isNull(service.getMetadata())) {
+                            LOG.warn("Service {} not found in namespace {}", labels.get(label), namespace);
+                            continue;
+                        }
+                        Map<String, String> metadataAnnotations = service.getMetadata().getAnnotations();
                         SofaRuleHandle ruleHandle = createSofaRuleHandle(annotations);
                         List<ConditionData> ruleConditionList = getRuleConditionList(metadataAnnotations);
                         RuleData ruleData = createRuleData(metadataAnnotations, ruleHandle, ruleConditionList);

shenyu-kubernetes-controller/src/test/java/org/apache/shenyu/k8s/parser/DubboIngressParserTest.java

@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.k8s.parser;
+
+import io.kubernetes.client.informer.SharedIndexInformer;
+import io.kubernetes.client.informer.cache.Indexer;
+import io.kubernetes.client.informer.cache.Lister;
+import io.kubernetes.client.openapi.models.V1EndpointAddress;
+import io.kubernetes.client.openapi.models.V1EndpointSubsetBuilder;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsBuilder;
+import io.kubernetes.client.openapi.models.V1HTTPIngressPathBuilder;
+import io.kubernetes.client.openapi.models.V1Ingress;
+import io.kubernetes.client.openapi.models.V1IngressBuilder;
+import io.kubernetes.client.openapi.models.V1IngressRule;
+import io.kubernetes.client.openapi.models.V1IngressRuleBuilder;
+import io.kubernetes.client.openapi.models.V1Service;
+import io.kubernetes.client.openapi.models.V1ServiceBuilder;
+import org.apache.shenyu.k8s.common.ShenyuMemoryConfig;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test for DubboIngressParser null-safety.
+ */
+public class DubboIngressParserTest {
+
+    private static final String NAMESPACE = "testNamespace";
+
+    private static final String SERVICE_NAME = "testService";
+
+    private Lister<V1Service> newServiceLister() {
+        final SharedIndexInformer<V1Service> informer = mock(SharedIndexInformer.class);
+        final Indexer<V1Service> indexer = mock(Indexer.class);
+        when(informer.getIndexer()).thenReturn(indexer);
+        return new Lister<>(indexer);
+    }
+
+    private Lister<V1Endpoints> newEndpointsLister() {
+        final SharedIndexInformer<V1Endpoints> informer = mock(SharedIndexInformer.class);
+        final Indexer<V1Endpoints> indexer = mock(Indexer.class);
+        final V1Endpoints endpoints = new V1EndpointsBuilder()
+                .withNewMetadata().withName(SERVICE_NAME).withNamespace(NAMESPACE).endMetadata()
+                .withSubsets(new V1EndpointSubsetBuilder()
+                        .withAddresses(new V1EndpointAddress().ip("127.0.0.1")).build())
+                .build();
+        when(indexer.getByKey(NAMESPACE + "/" + SERVICE_NAME)).thenReturn(endpoints);
+        when(informer.getIndexer()).thenReturn(indexer);
+        return new Lister<>(indexer);
+    }
+
+    @Test
+    public void testParseWithNullLabels() {
+        final Map<String, String> annotations = new HashMap<>();
+        annotations.put("kubernetes.io/ingress.class", "shenyu");
+        annotations.put("shenyu.apache.org/plugin-dubbo-enabled", "true");
+        annotations.put("shenyu.apache.org/upstreams-protocol", "dubbo://,dubbo://");
+
+        final V1IngressRule rule = new V1IngressRuleBuilder()
+                .withNewHttp()
+                .withPaths(new V1HTTPIngressPathBuilder()
+                        .withPath("/dubbo/findById")
+                        .withNewBackend()
+                        .withNewService().withName(SERVICE_NAME).withNewPort().withNumber(20888).endPort().endService()
+                        .endBackend().build())
+                .endHttp().build();
+
+        final V1Ingress ingress = new V1IngressBuilder()
+                .withNewMetadata().withName("testIngress").withNamespace(NAMESPACE)
+                .withAnnotations(annotations).withLabels(null).endMetadata()
+                .withNewSpec().withRules(rule).endSpec()
+                .build();
+
+        final DubboIngressParser parser = new DubboIngressParser(newServiceLister(), newEndpointsLister());
+        final ShenyuMemoryConfig result = parser.parse(ingress, null);
+        Assertions.assertNotNull(result);
+    }
+
+    @Test
+    public void testParseWithMissingService() {
+        final Map<String, String> annotations = new HashMap<>();
+        annotations.put("kubernetes.io/ingress.class", "shenyu");
+        annotations.put("shenyu.apache.org/plugin-dubbo-enabled", "true");
+        annotations.put("shenyu.apache.org/upstreams-protocol", "dubbo://,dubbo://");
+
+        final Map<String, String> labels = new HashMap<>();
+        labels.put("shenyu.apache.org/metadata-labels-1", "nonExistentService");
+
+        final V1IngressRule rule = new V1IngressRuleBuilder()
+                .withNewHttp()
+                .withPaths(new V1HTTPIngressPathBuilder()
+                        .withPath("/dubbo/findById")
+                        .withNewBackend()
+                        .withNewService().withName(SERVICE_NAME).withNewPort().withNumber(20888).endPort().endService()
+                        .endBackend().build())
+                .endHttp().build();
+
+        final V1Ingress ingress = new V1IngressBuilder()
+                .withNewMetadata().withName("testIngress").withNamespace(NAMESPACE)
+                .withAnnotations(annotations).withLabels(labels).endMetadata()
+                .withNewSpec().withRules(rule).endSpec()
+                .build();
+
+        final DubboIngressParser parser = new DubboIngressParser(newServiceLister(), newEndpointsLister());
+        final ShenyuMemoryConfig result = parser.parse(ingress, null);
+        Assertions.assertNotNull(result);
+    }
+
+    @Test
+    public void testParseWithValidLabelsAndService() {
+        final SharedIndexInformer<V1Service> serviceInformer = mock(SharedIndexInformer.class);
+        final Indexer<V1Service> serviceIndexer = mock(Indexer.class);
+        when(serviceInformer.getIndexer()).thenReturn(serviceIndexer);
+
+        final Map<String, String> annotations = new HashMap<>();
+        annotations.put("kubernetes.io/ingress.class", "shenyu");
+        annotations.put("shenyu.apache.org/plugin-dubbo-enabled", "true");
+        annotations.put("shenyu.apache.org/upstreams-protocol", "dubbo://,dubbo://");
+
+        final Map<String, String> labels = new HashMap<>();
+        labels.put("shenyu.apache.org/metadata-labels-1", "dubboFindIdService");
+
+        final Map<String, String> serviceAnnotations = new HashMap<>();
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-app-name", "dubbo");
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-path", "/findById");
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-rpc-type", "dubbo");
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-service-name",
+                "org.apache.shenyu.examples.dubbo.api.service.DubboTestService");
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-method-name", "findById");
+        serviceAnnotations.put("shenyu.apache.org/plugin-dubbo-params-type", "java.lang.String");
+
+        final V1Service dubboService = new V1ServiceBuilder()
+                .withNewMetadata().withName("dubboFindIdService").withNamespace(NAMESPACE)
+                .withAnnotations(serviceAnnotations).endMetadata()
+                .build();
+        when(serviceIndexer.getByKey(NAMESPACE + "/dubboFindIdService")).thenReturn(dubboService);
+
+        final V1IngressRule rule = new V1IngressRuleBuilder()
+                .withNewHttp()
+                .withPaths(new V1HTTPIngressPathBuilder()
+                        .withPath("/dubbo/findById")
+                        .withNewBackend()
+                        .withNewService().withName(SERVICE_NAME).withNewPort().withNumber(20888).endPort().endService()
+                        .endBackend().build())
+                .endHttp().build();
+
+        final V1Ingress ingress = new V1IngressBuilder()
+                .withNewMetadata().withName("testIngress").withNamespace(NAMESPACE)
+                .withAnnotations(annotations).withLabels(labels).endMetadata()
+                .withNewSpec().withRules(rule).endSpec()
+                .build();
+
+        final Lister<V1Service> serviceLister = new Lister<>(serviceIndexer);
+        final Lister<V1Endpoints> endpointsLister = newEndpointsLister();
+        final DubboIngressParser parser = new DubboIngressParser(serviceLister, endpointsLister);
+        final ShenyuMemoryConfig result = parser.parse(ingress, null);
+        Assertions.assertNotNull(result);
+        Assertions.assertNotNull(result.getRouteConfigList());
+        Assertions.assertFalse(result.getRouteConfigList().isEmpty());
+    }
+}