[feat] Add consumer interceptor - #210
Merged
Merged
Conversation
shibd
requested changes
Mar 16, 2023
shibd
approved these changes
Mar 16, 2023
Contributor
|
I don't think we need to implement the |
Member
Author
As we discussed here: #169 (comment), we think it's a missing implementation for the java client. It doesn't make sense to expose the close method but it doesn't do anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #150
Motivation
This is the consumer interceptor implementation of #150.
There are some trigger events that are not implemented due to the current PR is big enough:
I will add them in another PR.
Modifications
interceptandgetInterceptorsinProducerConfiguration.beforeConsume,onAcknowledge,onAcknowledgeCumulativeandclose.Verifying this change
This change added tests.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)