[feat] Support partitioned topic reader. - #154
Merged
Merged
Conversation
BewareMyPower
requested changes
Jan 5, 2023
Contributor
|
@shibd Could you resolve the conflicts and address the comments? |
Member
Author
|
@BewareMyPower @RobertIndie PTAL, Because it blocked TableView pr. |
BewareMyPower
approved these changes
Feb 7, 2023
BewareMyPower
left a comment
BewareMyPower
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM. Just need to remove some const qualifiers on value parameters.
Co-authored-by: Yunze Xu <xyzinfernity@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation, Reader does not yet support partitioned topics.
Modifications
hasMessageAvailableandacknowledgeCumulativeAsyncmethod.Verifying this change
ReaderTestto multi-partition topic scenarios.ConsumerTest.testAcknowledgeCumulativeWithPartitionunit test to cover MultiTopicConsumer.acknowledgeCumulativeAsync method.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)