Make MSE QueryServer's gRPC permit keep-alive settings configurable#18354
Open
yashmayya wants to merge 1 commit intoapache:masterfrom
Open
Make MSE QueryServer's gRPC permit keep-alive settings configurable#18354yashmayya wants to merge 1 commit intoapache:masterfrom
yashmayya wants to merge 1 commit intoapache:masterfrom
Conversation
yashmayya
added
configuration
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18354 +/- ##
============================================
- Coverage 63.41% 63.40% -0.01%
Complexity 1679 1679
============================================
Files 3253 3253
Lines 198788 198796 +8
Branches 30793 30794 +1
============================================
- Hits 126064 126051 -13
- Misses 62651 62668 +17
- Partials 10073 10077 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18268, which added gRPC keep-alive on the broker MSE dispatch channels but left the matching server-side enforcement at Netty's defaults (
permitKeepAliveTime=5min,permitKeepAliveWithoutCalls=false). Operators tuning clientkeepAliveTimebelow 5 minutes (or enablingkeepAliveWithoutCalls) for faster silent-peer detection get their dispatch channels torn down withGOAWAY(ENHANCE_YOUR_CALM)once the server's bad-ping threshold is hit.This change exposes the corresponding server-side knobs on the MSE
QueryServer:pinot.query.multistage.query.server.permit.keep.alive.time.ms(default300_000, matches Netty)pinot.query.multistage.query.server.permit.keep.alive.without.calls(defaultfalse, matches Netty)Defaults preserve existing behavior, so this is a transparent upgrade.