Skip to content

HBASE-30126 Fix mismatched LoggerFactory class references (#8152)#8159

Merged
liuxiaocs7 merged 1 commit intoapache:branch-3from
liuxiaocs7:HBASE-30126-branch-3
Apr 29, 2026
Merged

HBASE-30126 Fix mismatched LoggerFactory class references (#8152)#8159
liuxiaocs7 merged 1 commit intoapache:branch-3from
liuxiaocs7:HBASE-30126-branch-3

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

Signed-off-by: Duo Zhang <zhangduo@apache.org>
@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 29, 2026 02:58
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect LoggerFactory.getLogger(...) class arguments across the codebase so log categories match the actual emitting classes (HBASE-30126).

Changes:

  • Updated many LoggerFactory.getLogger(OtherClass.class) calls to use the declaring class instead.
  • Removed a now-unneeded import in TestRegionReplicaFailover after fixing the logger reference.
  • Wrapped a couple of long logger initializations to match existing formatting.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java Logger now references HThreadedSelectorServerArgs instead of Thrift server class.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java Logger now references the correct test base class.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java Logger now references TestWALSplitToHFile.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotWhenChoreCleaning.java Logger now references TestSnapshotWhenChoreCleaning.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java Logger now references TestMobFlushSnapshotFromClient.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java Logger now references TestConcurrentFlushSnapshotFromClient (with line wrap).
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java Logger now references TestAccessController3.
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/EnableRSGroupsTestBase.java Logger now references EnableRSGroupsTestBase.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java Logger now references TestReplicationStuckWithDroppedTable.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java Logger now references TestLogRollAbort.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java Logger now references TestRegionReplicaFailover; removed stale import.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java Logger now references TestHRegionReplayEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java Logger now references TestWALEventTracker.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java Logger now references TestMasterProcedureEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java Logger now references TestMasterOperationsForRegionReplicas (with line wrap).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java Logger now references AbstractTestDLS.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/BasicReadWriteWithDifferentConnectionRegistriesTestBase.java Logger now references the correct test base class.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java Logger now references AbstractRecoveredEditsOutputSink.
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java Logger now references CanaryTool.
hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java Logger now references SaslServerAuthenticationProviders.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java Logger now references ReplicationSourceLogQueue.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Logger now references HFilePreadReader.
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java Logger now references MultiRowMutationEndpoint.
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java Logger now references ZKSplitLogManagerCoordination.
hbase-server/src/main/java/org/apache/hadoop/hbase/ExecutorStatusChore.java Logger now references ExecutorStatusChore.
hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java Logger now references MetricRegistriesLoader.
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatTestBase.java Logger now references MultiTableInputFormatTestBase.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Logger in CellSortImporter now references CellSortImporter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java Logger now references TestServletFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java Logger now references TestPathFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java Logger now references TestGlobalFilter.
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java Logger now references CompatibilityFactory.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java Logger now references ReusableStreamGzipCodec.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java Logger now references RawAsyncHBaseAdmin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 880b581 into apache:branch-3 Apr 29, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants