HBASE-30126 Fix mismatched LoggerFactory class references (#8152)#8159
Merged
liuxiaocs7 merged 1 commit intoapache:branch-3from Apr 29, 2026
Merged
HBASE-30126 Fix mismatched LoggerFactory class references (#8152)#8159liuxiaocs7 merged 1 commit intoapache:branch-3from
liuxiaocs7 merged 1 commit intoapache:branch-3from
Conversation
Member
liuxiaocs7
commented
Apr 29, 2026
- see: HBASE-30126
Signed-off-by: Duo Zhang <zhangduo@apache.org>
There was a problem hiding this comment.
Pull request overview
Fixes incorrect LoggerFactory.getLogger(...) class arguments across the codebase so log categories match the actual emitting classes (HBASE-30126).
Changes:
- Updated many
LoggerFactory.getLogger(OtherClass.class)calls to use the declaring class instead. - Removed a now-unneeded import in
TestRegionReplicaFailoverafter fixing the logger reference. - Wrapped a couple of long logger initializations to match existing formatting.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java | Logger now references HThreadedSelectorServerArgs instead of Thrift server class. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java | Logger now references the correct test base class. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java | Logger now references TestWALSplitToHFile. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotWhenChoreCleaning.java | Logger now references TestSnapshotWhenChoreCleaning. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java | Logger now references TestMobFlushSnapshotFromClient. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java | Logger now references TestConcurrentFlushSnapshotFromClient (with line wrap). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java | Logger now references TestAccessController3. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/EnableRSGroupsTestBase.java | Logger now references EnableRSGroupsTestBase. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java | Logger now references TestReplicationStuckWithDroppedTable. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java | Logger now references TestLogRollAbort. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java | Logger now references TestRegionReplicaFailover; removed stale import. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java | Logger now references TestHRegionReplayEvents. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java | Logger now references TestWALEventTracker. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java | Logger now references TestMasterProcedureEvents. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java | Logger now references TestMasterOperationsForRegionReplicas (with line wrap). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java | Logger now references AbstractTestDLS. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/BasicReadWriteWithDifferentConnectionRegistriesTestBase.java | Logger now references the correct test base class. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java | Logger now references AbstractRecoveredEditsOutputSink. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java | Logger now references CanaryTool. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java | Logger now references SaslServerAuthenticationProviders. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java | Logger now references ReplicationSourceLogQueue. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java | Logger now references HFilePreadReader. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java | Logger now references MultiRowMutationEndpoint. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java | Logger now references ZKSplitLogManagerCoordination. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/ExecutorStatusChore.java | Logger now references ExecutorStatusChore. |
| hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java | Logger now references MetricRegistriesLoader. |
| hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatTestBase.java | Logger now references MultiTableInputFormatTestBase. |
| hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java | Logger in CellSortImporter now references CellSortImporter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java | Logger now references TestServletFilter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java | Logger now references TestPathFilter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java | Logger now references TestGlobalFilter. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java | Logger now references CompatibilityFactory. |
| hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java | Logger now references ReusableStreamGzipCodec. |
| hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java | Logger now references RawAsyncHBaseAdmin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.