Skip to content

fix(axis): Show min/max split line for all axis types#21579

Open
sebastianludwig wants to merge 4 commits intoapache:masterfrom
sebastianludwig:show-min-max-split-line
Open

fix(axis): Show min/max split line for all axis types#21579
sebastianludwig wants to merge 4 commits intoapache:masterfrom
sebastianludwig:show-min-max-split-line

Conversation

@sebastianludwig
Copy link
Copy Markdown

@sebastianludwig sebastianludwig commented Apr 14, 2026

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add the missing implementation of splitLine.showMinLine/.showMaxLine to radius, angle and single axis. Also add support for these properties to axisLine for polar angle axis.

Details

Before: What was the problem?

#20114 added splitLine.showMinLine and .showMaxLine and implemented it for the cartesian axis. The current documentation shows the option to be supported for other axis as well:

However there was simply no implementation in place. This PR fixes that.

Also, while on it, I also added support for these properties to axisLine for polar angle axis.

After: How does it behave after the fixing?

The split line fix

Screenshot 2026-04-14 at 13 18 06 Screenshot 2026-04-14 at 13 18 29 Screenshot 2026-04-14 at 13 18 50

The axis line feature

Screenshot 2026-04-14 at 13 19 44 Screenshot 2026-04-14 at 13 19 59 Screenshot 2026-04-14 at 13 20 15 Screenshot 2026-04-14 at 13 20 29 Screenshot 2026-04-14 at 13 20 44

Document Info

One of the following should be checked.

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Merging options

  • Please squash the commits into a single one when merging.

Other information

This is my first PR in this repo. Please let me know if I missed some of the conventions.

@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Apr 14, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.

Comment thread src/component/axis/AngleAxisView.ts Outdated
@Justin-ZS
Copy link
Copy Markdown
Contributor

Justin-ZS commented Apr 17, 2026

Thanks for the PR. The overall direction looks good, and the splitLine coverage extension to radius/angle/single plus added test pages is very helpful. I left one inline comment on AngleAxisView for a possible category-axis boundary edge case. Other than that, this looks solid.

@sebastianludwig sebastianludwig force-pushed the show-min-max-split-line branch from 274cb4a to 04467c4 Compare April 18, 2026 13:29
@sebastianludwig
Copy link
Copy Markdown
Author

Good catch! I've implemented a test case showcasing the problem you foresaw

Screenshot 2026-04-18 at 15 15 19

Next I changed the implementation as suggested to use radiusAxis.getExtent() directly and now the chart looks like this/correct:

Screenshot 2026-04-18 at 15 29 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants