Ftr: add raw unary trailer support to core#205
Open
CoderSerio wants to merge 23 commits into
Open
Conversation
Author
|
The CI license checker failure seems unrelated to this PR....🤨 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
TripleClient::raw_unary_with_trailersto expose HTTP/2 response trailers separately from response metadata.dubbo-rs-core::RawTripleClient::unaryto return response headers and trailers as separateRawMetadatafields.TripleClient::raw_unarybehavior compatible by merging trailers into metadata as before.Why
dubbo-rs-coreis intended to provide a stable, byte-oriented core SDK that can be embedded by other runtimes.One important use case is Dubbo JS. Instead of reimplementing all Triple transport and governance capabilities in JavaScript, Dubbo JS can wrap selected dubbo-rust core APIs through N-API and reuse the Rust runtime. To make that boundary correct, the raw unary API needs to preserve Triple/gRPC semantics, including keeping response headers and trailers separate.
Test