Repository navigation
[Improvement-18684][TaskPlugin] Trim whitespace in ShellParameters.checkParameters - #18685
Merged
Merged
Conversation
chovy-3012
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
October 9, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO.
Purpose of the pull request
ShellParameters.checkParameters()only checksrawScript != null && !rawScript.isEmpty()without trimming. A whitespace-only script (e.g." \n\t ") passes validation and creates a meaningless empty task.Closes #18684
Brief change log
ShellParameters.java:checkParameters()usetrim()to reject whitespace-only scriptsShellParametersTest.java: Add 4 unit tests covering null, empty, valid, and whitespace-only scriptsVerify this pull request
This change added tests and can be verified as follows:
Pull Request Notice
Pull Request Notice