Skip to content

Internal refactorings for Locales #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 1 commit into from
Jun 6, 2026
+112 −234
Merged

Internal refactorings for Locales #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/main/java/org/apache/commons/validator/DateValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,7 @@ public boolean isValid(final String value, final Locale locale) {
if (value == null) {
return false;
}
final DateFormat formatter;
if (locale != null) {
formatter = DateFormat.getDateInstance(DateFormat.SHORT, locale);
} else {
formatter = DateFormat.getDateInstance(DateFormat.SHORT, Locale.getDefault());
}
final DateFormat formatter = DateFormat.getDateInstance(DateFormat.SHORT, Validator.toLocale(locale));
formatter.setLenient(false);
try {
formatter.parse(value);
Expand All @@ -97,27 +92,19 @@ public boolean isValid(final String value, final Locale locale) {
* @return true if the date is valid.
*/
public boolean isValid(final String value, final String datePattern, final boolean strict) {

if (value == null
|| datePattern == null
|| datePattern.isEmpty()) {

if (value == null || datePattern == null || datePattern.isEmpty()) {
return false;
}

final SimpleDateFormat formatter = new SimpleDateFormat(datePattern);
formatter.setLenient(false);

try {
formatter.parse(value);
} catch (final ParseException e) {
return false;
}

if (strict && datePattern.length() != value.length()) {
return false;
}

return true;
}

Expand Down
Loading
Loading