Fix CLI error handling and exit codes for failed commands#65052
Open
rjgoyln wants to merge 1 commit intoapache:mainfrom
Open
Fix CLI error handling and exit codes for failed commands#65052rjgoyln wants to merge 1 commit intoapache:mainfrom
rjgoyln wants to merge 1 commit intoapache:mainfrom
Conversation
bugraoz93
requested changes
Apr 11, 2026
Contributor
bugraoz93
left a comment
There was a problem hiding this comment.
Thanks! I think this needs revision
| f"[red]Server response error: {e}. " | ||
| "Please check if the server is running and the API URL is correct.[/red]" | ||
| ) | ||
| sys.exit(1) |
Contributor
There was a problem hiding this comment.
We are specifically not exit anything api side of the code. Id you think this isn't handled, I would suggest add into cli_config.py safe_call where we directly handle exceptions at the most closest to user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in CLI error handling where certain failures (e.g. network or server errors) were only printed but did not cause the process to exit with a non-zero status code.
As a result, CI systems could incorrectly interpret failed executions as successful runs.
This change ensures proper error propagation and correct exit code behavior for CLI failures.
Changes
sys.exit(1)is triggered on all failure casesWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.