Repository navigation
fix(computer-use): quote key and modifier arguments - #515
Open
BichengWang wants to merge 1 commit into
Open
BichengWang wants to merge 1 commit into
BichengWang wants to merge 1 commit into
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Computer Use demo interpolates key and modifier strings into shell commands without quoting them. A semicolon is consumed as shell syntax, an apostrophe causes a parse error, and
$(...)executes a substitution instead of reachingxdotoolliterally. This affects the olderkeyactions and the click/scroll modifier paths inherited by the current computer toolset.Quote these arguments with
shlex.quote, matching the existing handling for typing, held keys, and toolset key presses. Add regressions that run the real shell with a localxdotoolstand-in and assert the arguments it receives.Quickstart
Type of Change
Testing
On macOS with Python 3.11.17 and the demo's development dependencies:
AsyncMockwarnings.tests/tools/edit_test.py.Screenshots
Not applicable.
Additional Notes
Validation ran offline. The regressions use a local executable to observe shell arguments and mock screenshots; actual X server, Docker/GUI, and live model checks were not run.