fix(sender): sync controlled speech recording state#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 本次变更属于 ...
🔗 相关 Issue
修复 Sender
allowSpeech受控模式下录音状态切换回调与外部状态不同步的问题。💡 背景与方案
Sender在allowSpeech使用对象配置且传入recording时,会进入受控录音模式。此前内部仍使用本地recordingref 作为按钮状态与下一次回调值的来源,导致外部更新recording后,内部状态可能不同步。本次调整新增
mergedRecording:allowSpeech.recording作为当前录音状态;recordingref;onRecordingChange入参;recording从false更新到true后再次点击应回调false。📝 变更日志
recording不同步的问题。