refactor(tool): destroy Truncate facade, effectify Tool.define#22093
Merged
kitlangton merged 3 commits intodevfrom Apr 12, 2026
Merged
refactor(tool): destroy Truncate facade, effectify Tool.define#22093kitlangton merged 3 commits intodevfrom
kitlangton merged 3 commits intodevfrom
Conversation
…n wrap Services are resolved at define-time (in registry context), passed into wrap as closed-over values. Info.init() and Tool.init() stay R=never. Tests updated to provide Truncate.defaultLayer and Agent.defaultLayer.
Execute the webfetch tool inside the same provided Effect scope used for initialization so the HTTP client layer stays alive for the assertions instead of interrupting the test fibers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeRuntimeandoutputfacade fromTruncateTool.defineto yieldTruncate.ServiceandAgent.Serviceat define-time, passing them intowrapas closed-over valuesInfo.init()andTool.init()remain R=never — no leaked requirementstool.tsno longer usesEffect.promise(() => Agent.get(...))facade — uses the service directlyTruncate.defaultLayerandAgent.defaultLayerVerification
bun run typecheck— cleanbun run test test/tool/truncation.test.ts test/tool/tool-define.test.ts test/tool/grep.test.ts— 23/23