Repository navigation
refactor: use kotlinx.serialization for DB requests - #755
Merged
Merged
Conversation
criticalAY
previously requested changes
Oct 3, 2026
criticalAY
left a comment
criticalAY
left a comment
There was a problem hiding this comment.
This is a soft approve, nothing major
Comment on lines
+277
to
+278
| this is Double && equals(-0.0) -> "-0" | ||
| value == asLong.toDouble() -> asLong.toString() |
There was a problem hiding this comment.
JsonPrimitive(this as Number) and JsonPrimitive(asLong) give identical output
Member
Author
There was a problem hiding this comment.
Double 3.0: JsonPrimitive(Number)=3.0; JsonPrimitive(asLong)=3
Float 3.0: JsonPrimitive(Number)=3.0; JsonPrimitive(asLong)=3
Long 3: JsonPrimitive(Number)=3; JsonPrimitive(asLong)=3
Double 1.75123456789E12: JsonPrimitive(Number)=1.75123456789E12; JsonPrimitive(asLong)=1751234567890
Double -0.0: JsonPrimitive(Number)=-0.0; JsonPrimitive(asLong)=0
Float -0.0: JsonPrimitive(Number)=-0.0; JsonPrimitive(asLong)=0
Double 0.0: JsonPrimitive(Number)=0.0; JsonPrimitive(asLong)=0
Float 0.0: JsonPrimitive(Number)=0.0; JsonPrimitive(asLong)=0
Replace `org.json`, but keep wire compatibility * except for '/' escaping - not needed Assisted-by: GPT-6
Assisted-by: GPT-6
david-allison
force-pushed
the
java-library-9
branch
from
October 3, 2026 23:25
1d9320b to
26ec1b6
Compare
david-allison
enabled auto-merge
October 6, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another
org.jsonreference down