Repository navigation
Complete Direction B design migration, fix profile/notification bugs - #46
Merged
Merged
Conversation
…state and pinned user block
…nge cards, friends row
…reserve Turbo Frame search
…cent, preserve Turbo wiring
- Duels, categories, invitations, admin categories, admin settings all updated to Direction B dark minimal design system - Notifications bell now navigates to notifications_path instead of opening a dropdown Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… bugs Finish applying the dark/minimal Direction B design across every remaining page (categories, posts, admin, notifications, users, discussions), replace the notifications bell with a regular sidebar link showing an unread badge, and wire up the Timed Mock feature end to end (routes, User#mocks association, home page card). Also fixes two bugs found during verification: a crash when truncating rich-text post bodies on profile pages, and a Devise Warden error when posts partials render from Turbo Stream broadcasts outside a request context.
Spins up Postgres and Redis service containers, loads the schema, builds Tailwind CSS, and runs bin/rails test on every PR and push to main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Before:
bin/rails test→ 4 failures, 1 error (stale leaderboard assertions, old chip markup, Devise/Warden crash on broadcast render)After:
bin/rails test→ 134 runs, 302 assertions, 0 failures, 0 errorsBefore: Notifications bell icon only, hidden among user-block controls at the bottom of the sidebar
After: Notifications is a top-level sidebar link (same row styling as Challenges/Games/Discussions) with an unread-count badge
Verified in a real Chromium browser (Playwright) at 375/768/1440px across ~24 pages (home, mocks, challenges, discussions, categories, posts, admin, notifications, users, profile, edit profile) — no horizontal overflow, no JS console errors
Merge Danger
Door: Two-way — purely visual/CSS and helper-guard changes; easy to revert with
git revert.Blast Radius: App-wide (every page touches the shared Tailwind stylesheet and sidebar partial), but changes are additive/cosmetic rather than structural — no schema changes beyond the already-separate Mock feature migration, no removed routes.