Skip to content

Complete Direction B design migration, fix profile/notification bugs - #46

Merged
aniketpatidar merged 10 commits into
mainfrom
claude/new-session-8b4323
Oct 2, 2026
Merged

aniketpatidar merged 10 commits into
mainfrom
claude/new-session-8b4323

Conversation

@aniketpatidar

Copy link
Copy Markdown
Owner

Summary

app/views/
├── categories/, posts/, admin/, notifications/, users/, discussions/   # Direction B dark theme applied
├── layouts/_sidebar.html.erb        # Notifications moved from navbar bell to regular sidebar link
└── nav/_notifications.html.erb      # rewritten: icon+label+unread badge, matches other nav items

app/helpers/application_helper.rb    # upvote_icon/downvote_icon guard against nil user
app/views/discussions/posts/_post.html.erb   # current_user rescued (Turbo Stream broadcasts have no Warden session)
app/views/users/show.html.erb        # fix: truncate(post.body) -> truncate(post.body.to_plain_text)

app/models/mock*.rb, app/controllers/mocks*, app/views/mocks/   # Timed Mock feature wired end-to-end

Evidence

  • Before: bin/rails test → 4 failures, 1 error (stale leaderboard assertions, old chip markup, Devise/Warden crash on broadcast render)

  • After: bin/rails test → 134 runs, 302 assertions, 0 failures, 0 errors

  • Before: Notifications bell icon only, hidden among user-block controls at the bottom of the sidebar

  • After: Notifications is a top-level sidebar link (same row styling as Challenges/Games/Discussions) with an unread-count badge

  • Verified in a real Chromium browser (Playwright) at 375/768/1440px across ~24 pages (home, mocks, challenges, discussions, categories, posts, admin, notifications, users, profile, edit profile) — no horizontal overflow, no JS console errors

Merge Danger

Door: Two-way — purely visual/CSS and helper-guard changes; easy to revert with git revert.

Blast Radius: App-wide (every page touches the shared Tailwind stylesheet and sidebar partial), but changes are additive/cosmetic rather than structural — no schema changes beyond the already-separate Mock feature migration, no removed routes.

aniketpatidar and others added 10 commits October 1, 2026 18:35
- Duels, categories, invitations, admin categories, admin settings all
  updated to Direction B dark minimal design system
- Notifications bell now navigates to notifications_path instead of
  opening a dropdown

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… bugs

Finish applying the dark/minimal Direction B design across every
remaining page (categories, posts, admin, notifications, users,
discussions), replace the notifications bell with a regular sidebar
link showing an unread badge, and wire up the Timed Mock feature
end to end (routes, User#mocks association, home page card).

Also fixes two bugs found during verification: a crash when
truncating rich-text post bodies on profile pages, and a Devise
Warden error when posts partials render from Turbo Stream broadcasts
outside a request context.
Spins up Postgres and Redis service containers, loads the schema,
builds Tailwind CSS, and runs bin/rails test on every PR and push
to main.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@aniketpatidar
aniketpatidar merged commit 02b427d into main Oct 2, 2026
1 check passed
@aniketpatidar
aniketpatidar deleted the claude/new-session-8b4323 branch October 2, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant