refactor(aria/tabs): clean up tab selection and linking to panels, add direct template ref#32859
Open
adolgachev wants to merge 3 commits intoangular:mainfrom
Open
refactor(aria/tabs): clean up tab selection and linking to panels, add direct template ref#32859adolgachev wants to merge 3 commits intoangular:mainfrom
adolgachev wants to merge 3 commits intoangular:mainfrom
Conversation
|
Deployed dev-app for edf03c8 to: https://ng-dev-previews-comp--pr-angular-components-32859-dev-pxtvzh2b.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for edf03c8 to: https://ng-dev-previews-comp--pr-angular-components-32859-docs-58cy5tjn.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
9f18364 to
cb3c051
Compare
f6c32a1 to
d913ebb
Compare
be451be to
45041c5
Compare
fd5f0bb to
96f2cbb
Compare
54ee045 to
fa930ac
Compare
Member
|
We should put this change on hold for two main reasons
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors Tabs pattern to simplify how tabs are associated with their tab panels, as well as other dependent code.
This is a revision of the previous approach which swapped to use contentChildren and template references only. Instead there are 3 commits with layered changes: