Repository navigation
refactor(categories): precompute section splits; benchmark follow-ups - #41
Merged
Merged
Conversation
- Parse each category .md once at init into parsedCategories; the Shapes/Review getters become map lookups instead of re-running splitSections per call (was ~4x per review on the hot path). Prompt output and cache keys are byte-identical. - Document the unmigrated GetCategoryShapes pass-through as intentional. - Make the deep-review benchmark's AOI scan provider-agnostic: follow cfg.FastModel (override via PRR_AOI_MODEL), skip only when a keyed provider lacks a key — so it runs keyless via claude-code. - Record measured Opus 4.8 deep-review benchmark numbers on DefaultStrongModel. - Add init-drift and unmigrated-fallback tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from reviewing the merged category Shapes/Review-criteria split (#40):
.mdis embedded and static, but the Shapes/Review getters were re-runningsplitSectionson every call — ~4× per review on the hot path (once perGetShape/GetReviewCriteriaper AOI, and again for the cache key vs. prompt build). Now each file is parsed once intoparsedCategoriesatinit(); the getters are map lookups. Prompt output and cache keys are byte-identical.GetCategoryShapesfallback as an intentional whole-file pass-through (surface everything rather than silently drop patterns).cfg.FastModel(override viaPRR_AOI_MODEL), pulls tuning from the model config, and skips only when a keyed provider lacks a key — so the benchmark runs keyless viaclaude-code.DefaultStrongModel(deep-review benchmark: 100% recall, 0 FP, 77% severity accuracy).Context
No behavior change to review/AOI prompts — the refactor preserves the recall-vs-precision split byte-for-byte (AOI scan gets Shapes only; deep review gets scoped Shapes + Review criteria). The benchmark change enabled validating the Opus 4.8 default keyless, which produced the figures now in the
config.gocomment.