WIP: sdhci-dwc: adsp-sc598: consume emmc_timer_cmq clock - #3487
Draft
sipraga wants to merge 1 commit into
Draft
Conversation
Fixes an odd race. Need to understand when/why this clock is needed. To reproduce: build with CONFIG_MMC_SDHCI_OF_DWCMSHC=m and boot rootfs over NFS. Then mmc will probe much later than the disabling of unused clocks. emmc_timer_cmq is then disabled and you hit the error. Another issue: the clock in the DT headers is mislabelled QMC. Also in the clock driver. To fix...
Contributor
Author
|
Need to learn more about this clock before merging. Just putting this here as a fix in case people are blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an odd race. Need to understand when/why this clock is needed.
To reproduce: build with CONFIG_MMC_SDHCI_OF_DWCMSHC=m and boot rootfs over NFS. Then mmc will probe much later than the disabling of unused clocks. emmc_timer_cmq is then disabled and you hit the error.
Another issue: the clock in the DT headers is mislabelled QMC. Also in the clock driver. To fix...
PR Description
necessary to understand them. List any dependencies required for this change.
any space), or simply check them after publishing the PR.
description and try to push all related PRs simultaneously.
PR Type
PR Checklist