Skip to content

Acceptance follow-up for #642: two criteria met only in part #661

Open

Description

@amritk

#642 (464f41e, "fix(checker): a moved secret's aliases are moved too") passed every gate. Its dynamic acceptance on merged main is SHIP (#625, <!-- feature:acceptance -->). The static acceptance pass marked two of its nine criteria PARTIAL. Neither is a defect in the merged code. Each is a call for the owner.

Criterion 5: the mutation pin. The brief asked that, with the fix reverted, every new negative compile. The pin, nish:secret: reverting the sole-reference rule lets every reject_secret_alias_* case compile (${aliasCases.length} cases), requires 38 of the 39 reject_secret_alias_* cases to compile. reject_secret_alias_declarator_moved is exempt by name, because the existing moved-read rule (NL2445) refuses it with or without this fix. It pins the declarator shape for that rule, not for this one. Decide whether the exemption stands, or the case should be renamed out of the reject_secret_alias_ set so that the pin covers every case in it.

Criterion 9: neutral wording before the merge. The PR title, the squash subject, and #625's title and body are neutral. But two kinds of public text described the behaviour while the PR was open:

  • the PR body, which is outside the brief's letter (issues, PR title, commit subject) but not its intent;
  • two of Feature: secret-alias-move #625's ledger comments, which named specific routes during review.

Nothing is left to change now that the fix is merged. This is recorded so the process can be adjusted for the next fix of this kind. A proposed CLAUDE.md line is in #625's close-out comment.

Tracking: #625.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions